Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented R-Precision for IR #577

Merged
merged 8 commits into from
Oct 22, 2021
Merged

Implemented R-Precision for IR #577

merged 8 commits into from
Oct 22, 2021

Conversation

lucadiliello
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #574 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 21, 2021 •
edited
Loading

Codecov Report

Merging #577 (1263468) into master (40007e9) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #577   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         144    146    +2     
  Lines        5032   5052   +20     
=====================================
+ Hits         4787   4805   +18     
- Misses        245    247    +2

SkafteNicki
SkafteNicki approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]
Great work @lucadiliello

@mergify mergify bot added the ready label Oct 22, 2021
@SkafteNicki SkafteNicki added this to the v0.6 milestone Oct 22, 2021
Borda
Borda approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Borda Borda enabled auto-merge (squash) October 22, 2021 13:48
auto-merge was automatically disabled October 22, 2021 14:18

Head branch was pushed to by a user without write access

@SkafteNicki SkafteNicki enabled auto-merge (squash) October 22, 2021 14:40
auto-merge was automatically disabled October 22, 2021 15:19

Head branch was pushed to by a user without write access

@mergify mergify bot removed the has conflicts label Oct 22, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) October 22, 2021 17:00
@SkafteNicki SkafteNicki merged commit 5bbfac5 into Lightning-AI:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@edenlightning edenlightning Awaiting requested review from edenlightning

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
New metric ready
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Add R-Precision for Information Retrieval
3 participants
@lucadiliello @Borda @SkafteNicki